From c14b43208228a871fe89f41e91b975bacef9cad2 Mon Sep 17 00:00:00 2001 From: mohamad Date: Sun, 1 Jun 2025 18:15:22 +0200 Subject: [PATCH] refactor: Encapsulate enum creation logic within a dedicated function in the upgrade process for improved readability and maintainability --- be/alembic/versions/0001_initial_schema.py | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/be/alembic/versions/0001_initial_schema.py b/be/alembic/versions/0001_initial_schema.py index bf86155..21be9c3 100644 --- a/be/alembic/versions/0001_initial_schema.py +++ b/be/alembic/versions/0001_initial_schema.py @@ -26,13 +26,16 @@ chore_frequency_enum = postgresql.ENUM('one_time', 'daily', 'weekly', 'monthly', chore_type_enum = postgresql.ENUM('personal', 'group', name='choretypeenum', create_type=False) def upgrade(context) -> None: - user_role_enum.create(op.get_bind(), checkfirst=True) - split_type_enum.create(op.get_bind(), checkfirst=True) - expense_split_status_enum.create(op.get_bind(), checkfirst=True) - expense_overall_status_enum.create(op.get_bind(), checkfirst=True) - recurrence_type_enum.create(op.get_bind(), checkfirst=True) - chore_frequency_enum.create(op.get_bind(), checkfirst=True) - chore_type_enum.create(op.get_bind(), checkfirst=True) + def create_enums(): + user_role_enum.create(op.get_bind(), checkfirst=True) + split_type_enum.create(op.get_bind(), checkfirst=True) + expense_split_status_enum.create(op.get_bind(), checkfirst=True) + expense_overall_status_enum.create(op.get_bind(), checkfirst=True) + recurrence_type_enum.create(op.get_bind(), checkfirst=True) + chore_frequency_enum.create(op.get_bind(), checkfirst=True) + chore_type_enum.create(op.get_bind(), checkfirst=True) + + create_enums() op.create_table('users', sa.Column('id', sa.Integer(), nullable=False), -- 2.45.2